Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

problem : zdir test fails on windows/release #1609

Merged
merged 1 commit into from
Jan 21, 2017
Merged

problem : zdir test fails on windows/release #1609

merged 1 commit into from
Jan 21, 2017

Conversation

bbdb68
Copy link
Contributor

@bbdb68 bbdb68 commented Jan 21, 2017

fix : rework the assert macros to avoid calls within assert.

problem :
51244da 
zdir test behaviour depends on assert macro being enabled

solution :
extract wait and poll calls from assert calls and use assert only
to check value.
@evoskuil evoskuil merged commit 6f93c71 into zeromq:master Jan 21, 2017
@bluca
Copy link
Member

bluca commented Jan 21, 2017

Wow all tests passing, finally! Thank you for all your work @bbdb68 !

@bbdb68 bbdb68 deleted the zdir_fix branch January 21, 2017 12:04
@sappo
Copy link
Member

sappo commented Jan 21, 2017

Neat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bbdb68 @bluca @sappo @evoskuil